Skip to content
This repository was archived by the owner on Aug 2, 2021. It is now read-only.

FUSE should not require --ipcpath #795

Closed
cobordism opened this issue Jul 16, 2018 · 7 comments · Fixed by ethereum/go-ethereum#18112
Closed

FUSE should not require --ipcpath #795

cobordism opened this issue Jul 16, 2018 · 7 comments · Fixed by ethereum/go-ethereum#18112
Assignees
Labels
cli Swarm command line interface enhancement good first issue

Comments

@cobordism
Copy link

Currently the command swarm fs mount theswarm.eth mountpoint will fail because swarm fs requires(!) the --ipcpath cli flag.

This should not be the case if swarm is running with the default ipc endpoint. If --ipcpath is not specified, it should simply be assumed the the ipcpath is DATDIR/bzzd.ipc

@zelig
Copy link
Member

zelig commented Nov 8, 2018

can i close this? @homotopycolimit @justelad ?

@acud
Copy link
Member

acud commented Nov 8, 2018

this was not yet merged to upstream. @frncmx?

@cobordism
Copy link
Author

it was merged to ethersphere but not to upstream.. so what needs to happen now?

@acud
Copy link
Member

acud commented Nov 9, 2018

@homotopycolimit it wasn't merged to ethersphere. there was just a PR that was reviewed and @frncmx said he will reopen on upstream

@cobordism
Copy link
Author

so we can close it here?

@acud
Copy link
Member

acud commented Nov 12, 2018

hab geduld

@frncmx frncmx self-assigned this Nov 14, 2018
@frncmx
Copy link
Contributor

frncmx commented Nov 14, 2018

Picking this one up now. There was some missing doc updates, that's why it was not ready for a merge.

frncmx pushed a commit that referenced this issue Nov 20, 2018
- Have `${DataDir}/bzzd.ipc` as IPC path default.
- Respect the `--datadir` flag.
- Keep only the global `--ipcpath` flag and drop the local `--ipcpath` flag
  as flags might overwrite each other. (Note: before global `--ipcpath`
  was ignored even if it was set)

fixes #795
zelig referenced this issue in ethereum/go-ethereum Nov 23, 2018
- Have `${DataDir}/bzzd.ipc` as IPC path default.
- Respect the `--datadir` flag.
- Keep only the global `--ipcpath` flag and drop the local `--ipcpath` flag
  as flags might overwrite each other. (Note: before global `--ipcpath`
  was ignored even if it was set)

fixes ethersphere#795
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
cli Swarm command line interface enhancement good first issue
Projects
None yet
4 participants