Don’t unnecessarily invalidate the module map #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional imports in PureScript sources (compared to their JavaScript output) shouldn’t always invalidate the module map because imports of types are erased and re-exports are followed. Also `Prim.*` modules are internal to the compiler and won’t ever be present in the module map.
|
Thanks for this PR. I will take a look soon. |
Otherwise the following expression ```purs hello :: Effect Unit hello = log "Hello" ``` includes the whole `Prelude` into its chunk whereas only `log` is actually needed at runtime.
|
The last commit makes bundles made by webpack without |
|
Great! Thanks for working on this. Is this good to go? |
|
Yes it is! |
|
Thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Additional imports in PureScript sources (compared to their JavaScript output) shouldn’t always invalidate the module map because imports of types are erased and re-exports are followed.
Also
Prim.*modules are internal to the compiler and won’t ever be present in the module map.Fix #123.