Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

serverstuff #25

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

serverstuff #25

wants to merge 12 commits into from

Conversation

Ulti-FD
Copy link

@Ulti-FD Ulti-FD commented Oct 8, 2021

polish to commands, text visibility, etc
needs full testing with multiple players since i only tested locally

♂️ FUCK YOU ♂️
also this didnt work anyways due to missing glyphs
Chart titles having randomized colors is an okay idea but its aweful for
readability. Sometimes it even makes the text actually unreadable
src/ettServer.ts Outdated Show resolved Hide resolved
@nico-abram
Copy link
Member

I skimmed the changes and they seem good to me. Haven't tested anything

@nico-abram
Copy link
Member

I just tested these changes locally, they seem to work fine.

The only thing that seems wrong to me is the "Building and Using" readme changes. You shouldn't have to manually run tsc, and for local tests/debugging you don't have to use pm2, yarn start should work fine. Could you change it to something like this?

## Building and Using

We use [yarn](https://yarnpkg.com/) instead of npm. Execute `yarn` in the root of the repository to install dependencies and build the project. Then `yarn start` to run the server. You can run `yarn start --help` to get a list of available options. You can also configure the server with environment variables, or with a .env file.

For a production environment, you can use [pm2](https://pm2.keymetrics.io/) like so: `pm2 start built/start.js --name multi`. pm2 will restart the server if it crashes, among other things.

To connect to a local server, disconnect from EO (from network options) and then connect to `127.0.0.1`. (The default server is `multi.etternaonline.com`)

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants