Replaced ECKey with AsymmetricJWK to get PublickKey #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
babisRoutis
requested changes
May 9, 2024
There was a problem hiding this comment.
@ydanneg Perhaps the holderPubKey parameter should be declared of type AsymmetricJWK.
Can you please change the type (using an import alias of NimbusAsymmetricJWK) ?
|
@ydanneg Also please run |
|
@ydanneg Please note I am on Easter vacations. Will check this next week. |
|
@ydanneg On second thought changing the parameter type will lead to some additional cascading changes. |
Absolutely fine with it! :) |
…n `keyBindingJWTProcess`
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #186