Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Do not consider kid when selecting/filtering keys resolved from a DID Document #235

Merged
merged 2 commits into from
Nov 11, 2024
Merged

Do not consider kid when selecting/filtering keys resolved from a DID Document #235

merged 2 commits into from
Nov 11, 2024

Conversation

dzarras
Copy link
Contributor

@dzarras dzarras commented Nov 6, 2024

Closes #234

@dzarras dzarras mentioned this pull request Nov 6, 2024
Closed
babisRoutis
babisRoutis previously approved these changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@babisRoutis babisRoutis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dzarras Minor comment

src/main/kotlin/eu/europa/ec/eudi/sdjwt/vc/SdJwtVcVerifier.kt Outdated Show resolved Hide resolved
@chumbert
Copy link

chumbert commented Nov 8, 2024

I tested this with our code and it works as expected.
My only change in our own code was disabling the kid override.

@babisRoutis
Copy link
Contributor

@dzarras I think PR looks good.
Please consider my comment and let's merge it

@babisRoutis babisRoutis added the feature New feature or request label Nov 11, 2024
@babisRoutis babisRoutis added this to the SdJwt-v0.6.4 milestone Nov 11, 2024
@babisRoutis babisRoutis marked this pull request as ready for review November 11, 2024 07:24
@babisRoutis babisRoutis requested a review from a team as a code owner November 11, 2024 07:24
@dzarras dzarras merged commit 758998a into eu-digital-identity-wallet:main Nov 11, 2024
4 checks passed
@dzarras dzarras deleted the fix/sd-jwt-vc-did-jwk-resolution branch November 11, 2024 08:13
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@babisRoutis babisRoutis babisRoutis approved these changes

Assignees
No one assigned
Labels
feature New feature or request
Projects
None yet
Milestone
SdJwt-v0.6.4
Development

Successfully merging this pull request may close these issues.

JWK kid and DID interactions with Nimbus verifier
3 participants
@dzarras @chumbert @babisRoutis