no implicit type casting #841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A large portion of the `evaluable.Pointwise` subclasses are holomorphic. This patch adds a subclass `evaluable.Holomorphic` derived from `Pointwise`, with a default implementation for `return_type` and support for complex derivatives, and lets the holomorphic pointwise array functions derive from `Holomorphic`. This patch also removes support for complex derivatives of subclasses of `Pointwise` (unless overriden).
The variable `evaluable._type_order` is an ordered tuple of dtypes: casting is safe to types to the right of a type. The function `evaluable.astype` is the only user of the orderedness of `evaluable._type_order`. This patch inlines the casting logic in `evaluable.astype`, leaving the orderedness of `evaluable._type_order` unused.
This patch formally removes the orderedness from the list of valid array dtypes by renaming `evaluable._type_order` to `evaluable._array_dtypes`.
joostvanzwieten
force-pushed
the
no-implicit-type-casting
branch
from
b425c2a to
9195274
Compare
gertjanvanzwieten
approved these changes
Dec 18, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many of the evaluable array ops (the functions, not the classes) support automatic type casting. For example you can do
evaluable.add(1, 1.5)without problems. However, you can also doevaluable.add(True, 1)(evaluates to 2, int), and here implicit casting makes less sense. To prevent unforeseen casts, this PR disallows all implicit casting in evaluable array ops.