fix SI handling of special binary methods #860
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch replaces the _drop suffix to _op as it was originally intended.
This patch moves the type interence from util.cli to the _infer_type helper function, and uses this in log_arguments. This fixes the situation in which arguments without type annotation were not logged correctly due to failing stringly serialization.
This patch introduces the SI.DimensionError class derived from TypeError, which is raised instead of TypeError whenever an operation fails due to incompatible units. In addition to allowing for more specific exception handling in general, this will be used in particular in a subsequent commit to handle failing dunder operations.
This patch fixes the behaviour or special binary methods (e.g. __add__) by returning NotImplemented upon failure rather than raising DimensionError. See https://docs.python.org/3.6/library/constants.html#NotImplemented.
joostvanzwieten
approved these changes
Mar 4, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the way that SI handles special binary methods such as
__add__by returningNotImplementedrather than raising aTypeError. Additionally it introduces a specialSI.DimensionError, and fixes two minor unrelated issues.