Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

1.21 compatible Version #34

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PhoenixofForce
Copy link

@PhoenixofForce PhoenixofForce commented Jul 26, 2024

Updated dependencies so that the plugin is compatible with 1.21.
You can download it on the release section on my fork
https://github.com/PhoenixofForce/HeadDrops/releases/tag/1.5.7

@K4sum1
Copy link

K4sum1 commented Oct 3, 2024

I tried this and even updated the dependencies further and built myself, and I can't get it to work. Player heads just don't drop.

@PhoenixofForce
Copy link
Author

I tried this and even updated the dependencies further and built myself, and I can't get it to work. Player heads just don't drop.

@K4sum1
I tested some, and had some problems. The thing was, that since I was opped I also had the 'headdrops.nodrop'-permissions which cancels the event. When I deopped myself it worked again (for the purpose of testing I set the dropchance to 1). Maybe this fixes your problem as well

@K4sum1
Copy link

K4sum1 commented Oct 23, 2024

Yeah, that might be it. Since I am already modifying the plugin, I might just remove permissions all together and make the plugin smaller and lighter as well.

Edit: I've never looked before but I did not expect permissions to just be that simple. Just a single line. Well, makes it much easier for me.

@K4sum1
Copy link

K4sum1 commented Oct 23, 2024

This is weird.

So the plugin needs string-utils, and you add that to your pom.xml as it was missing from the source.

However it compiles fine if you built it once with string-utils, then remove it. This also has a sizeable size reduction as well. More in line with the official published plugin. This feels weird, but I assume that since this is what the author did as far as I can tell and it seems to work completely fine, I'll do it as well.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants