This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Add colgroup to customizations #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChristophP
reviewed
May 1, 2017
| identity | ||
|
|
||
| Just { attributes, children } -> | ||
| (::) <| Html.caption attributes children |
There was a problem hiding this comment.
Maybe this could be simplified with Maybe.withDefault. Like
caption = Maybe.map (\{ attributes, children } -> (::) <| Html.caption attributes children) customizations.caption |> Maybe.withDefault identity
Not sure if its actually simpler but it would allow for more reuse if you broke some stuff up into smaller functions.
There was a problem hiding this comment.
I think it's harder to read your way. What I have takes more lines, but is easier to follow.
There was a problem hiding this comment.
Yeah, true. Might have been a microoptmization suggestion by me anyway :-).
Open
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
colgroup is useful for setting properties of whole columns (like width) easily. This would also address #12 (in fact, this is exactly the use case I have). Also, it is also part of HTML so we should include it.