This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Prevent Update Cycle On Unsortable Header Click #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Render header cells without an onClick handler, if they are unsortable.
This prevents an useless update cycle, caused by clicking the header
cell of an usortable column.
To make this possible the signature of the thead field in the
customization record is changed to accept a list of attributes instead
of a single attribute, which enables to pass an empty list if no onClick
handler should be added.
This commit breaks the public API. I understand that this is a problem, but it breaks only for people not using the default thead configuration and opens the possibility to add more attributes to the header cells in the future without breaking things.