This repository has been archived by the owner on Sep 6, 2018. It is now read-only.
Non-breaking space before sorting symbols #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gaul
reviewed
Mar 5, 2018
src/Table.elm
Outdated
| @@ -245,12 +245,12 @@ simpleTheadHelp (name, status, onClick) = | |||
|
|
|||
| darkGrey : String -> Html msg | |||
| darkGrey symbol = | |||
| Html.span [ Attr.style [("color", "#555")] ] [ Html.text (" " ++ symbol) ] | |||
| Html.span [ Attr.style [("color", "#555")] ] [ Html.text (" " ++ symbol) ] | |||
There was a problem hiding this comment.
More clear to use HTML entity, e.g., ?
Fix shadowing and toString problems. Change now nonexistent functions to floating point math. Add a CSS file for the example. Update live sample links to billstclair.github.io.
This was reported in evancz#15 Bump package version from 1.0.2 to 1.0.3.
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces the regular space between a column name and the sorting symbol with a non-breaking space, preventing wonky wrapping when the column's name is wider than the column's content.