Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Panic when adding to a non-existing array #171

Closed
sbueringer opened this issue Feb 6, 2023 · 1 comment
Closed

Panic when adding to a non-existing array #171

sbueringer opened this issue Feb 6, 2023 · 1 comment

Comments

@sbueringer
Copy link

sbueringer commented Feb 6, 2023 •
edited
Loading

Hey folks,

we discovered that we get a panic if we apply the following operations to a JSON:

  • op: replace, path: "/spec/template/spec/kubeadmConfigSpec/preKubeadmCommands", value: nil
  • op: add, path: "/spec/template/spec/kubeadmConfigSpec/preKubeadmCommands/0", value: "some text"

The panic occurs here:
https://github.com/evanphx/json-patch/blob/master/v5/patch.go#L509-L513

I think the problem is that it is only checked if next is nil, but not next.raw. So then it panics in l.513 at *next.raw.
@sbueringer sbueringer mentioned this issue Feb 6, 2023
Closed
evanphx added a commit that referenced this issue Jan 12, 2024
@evanphx
Merge pull request #196 from evanphx/b-null-mistype-panic
3da7b27 
Handle null correctly when introduced by replace. Fixes #171
@sbueringer
Copy link
Author

Thank you very much!!

@nflynt nflynt mentioned this issue Aug 6, 2024
Merged
1 task
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@sbueringer