-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Adapt sub-menus of 'Team' & 'Personal' menus UI #3023
Conversation
@Cedric921 , @evereq , @KostyaEver , I just corrected the problem with my account. |
wrapperClassName={`w-full border-t-0 border-r-0 border-b-0 rounded-none | ||
font-normal text-[#7e7991] justify-start pt-[24px] pb-[24px] pl-[24px] | ||
border-l-[5px] ${ | ||
activePage === '/settings/personal' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cedric921 can you check this PR, why we have this conditional styling and now it's removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cedric921 and @evereq , I'd noticed that the style shouldn't be conditioned by the "activePage" variable but with the "open" variable that headlessUI makes available to us in the SidebarAccordian component, so I just moved the code around and didn't delete anything.
wrapperClassName={`w-full border-t-0 border-r-0 border-b-0 rounded-none | ||
font-normal text-[#7e7991] justify-start text-sm pt-[24px] pb-[24px] pl-[24px] | ||
border-l-[5px] ${ | ||
activePage === '/settings/team' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Cedric921 can you check this PR, why we had this conditional styling and now it's removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
And since these are the same components as the previous one, I just adapted the rest.
Description
Please include a summary of the changes and the related issue.
I just adapted the sidebar menus of settings so that it is visible as requested in issue #3013
Type of Change
Checklist
Previous screenshots
Please add here videos or images of previous status
On #3013 issue
Current screenshots
Please add here videos or images of previous status