Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adapt sub-menus of 'Team' & 'Personal' menus UI #3023

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

land-bit
Copy link
Contributor

Description

Please include a summary of the changes and the related issue.

I just adapted the sidebar menus of settings so that it is visible as requested in issue #3013

Type of Change

  • Bug fix
  • New feature
  • Breaking change
  • Documentation update

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

Previous screenshots

Please add here videos or images of previous status

On #3013 issue

Current screenshots

Please add here videos or images of previous status

Capture d’écran du 2024-09-12 16-19-39

@land-bit
Copy link
Contributor Author

@Cedric921 , @evereq , @KostyaEver , I just corrected the problem with my account.

@Cedric921 Cedric921 added this to the v0.2.0 milestone Sep 13, 2024
wrapperClassName={`w-full border-t-0 border-r-0 border-b-0 rounded-none
font-normal text-[#7e7991] justify-start pt-[24px] pb-[24px] pl-[24px]
border-l-[5px] ${
activePage === '/settings/personal'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cedric921 can you check this PR, why we have this conditional styling and now it's removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cedric921 and @evereq , I'd noticed that the style shouldn't be conditioned by the "activePage" variable but with the "open" variable that headlessUI makes available to us in the SidebarAccordian component, so I just moved the code around and didn't delete anything.

wrapperClassName={`w-full border-t-0 border-r-0 border-b-0 rounded-none
font-normal text-[#7e7991] justify-start text-sm pt-[24px] pb-[24px] pl-[24px]
border-l-[5px] ${
activePage === '/settings/team'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Cedric921 can you check this PR, why we had this conditional styling and now it's removed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And since these are the same components as the previous one, I just adapted the rest.

@evereq evereq merged commit 793bd0c into ever-co:develop Sep 17, 2024
9 of 10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] 'Settings' | adapt sub-menus of 'Team' & 'Personal' menus UI
3 participants