provide examples field to set example value for a field. #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erosb
requested changes
Mar 16, 2020
There was a problem hiding this comment.
Hello @sreekesh93 , thank you for working on this.
Currently we don't support the "examples" keyword because it appeared only in the latest version of the json schema spec (2019-09), and we don't support this new version at all yet.
I think we can merge this PR once in the future, when we will start working on the 2019-09 draft version. Until then, please address my comment in the PR.
Thank you.
| public abstract S build(); | ||
|
|
||
| } | ||
| private final String examples; |
There was a problem hiding this comment.
A parsed Object would be much more useful than a string.
|
@erosb Thank you for the awesome library. Regarding the https://json-schema.org/understanding-json-schema/reference/generic.html?highlight=examples |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add feature to set examples for each json field as part of schema