fix: ccp_clean_html handle case if removing ccp styling results in empty string #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ccp_clean_html
converts the messages of evemails into browser-presentable html. The function currently crashes if it is called withu''
or a few other, specific messages.In the implementation,
DOMDocument->loadHTML
doesn't like empty strings. While we do have an empty string check at the top of the function, we apply transformations that can result in an empty string after the check, so it is possible that an empty string reachesDOMDocument->loadHTML
.