Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: ccp_clean_html handle case if removing ccp styling results in empty string #183

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

recursivetree
Copy link
Contributor

ccp_clean_html converts the messages of evemails into browser-presentable html. The function currently crashes if it is called with u'' or a few other, specific messages.

In the implementation, DOMDocument->loadHTML doesn't like empty strings. While we do have an empty string check at the top of the function, we apply transformations that can result in an empty string after the check, so it is possible that an empty string reaches DOMDocument->loadHTML.

@Crypta-Eve Crypta-Eve merged commit 52d6802 into eveseat:master Jan 9, 2025
1 check passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants