Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Confidently match horizontal separators in Huawei ont info summary #4

Merged
merged 8 commits into from
Jan 7, 2025

Conversation

mjbear
Copy link

@mjbear mjbear commented Dec 24, 2024

Addition to PR networktocode#1944

  • Resolve merge conflicts
  • Change horizontal separator rule to confidently match the separators and not other lines by accident

(Even though these are before the state transition to ONTs state, we probably should tweak the horizontal separator rule to be sure.)

@mjbear
Copy link
Author

mjbear commented Dec 28, 2024

@evilmonkey19
When you're back from winter break 😅 and have a few, please take a look at this PR.
Thank you!

@evilmonkey19
Copy link
Owner

@mjbear I'm back from the winter break! Thaaanks :) I will check it out now

@evilmonkey19 evilmonkey19 merged commit ab143f8 into evilmonkey19:master Jan 7, 2025
@evilmonkey19
Copy link
Owner

Merged! 🤘

@mjbear mjbear deleted the huawei_ont_info_sum_pr1944 branch January 7, 2025 18:36
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants