Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove unused parameters #829

Merged
merged 2 commits into from
Feb 5, 2023

Conversation

SpencerIsGiddy
Copy link
Contributor

Removes unused parameters in to define paint cell

@gustavo-iniguez-goya
Copy link
Collaborator

This change causes the GUI to crash. You need to update the call to paintCell() in order to match the function definition:

self.paintCell(
style,
painter,
option,
index,
defaultPen,
defaultBrush,
cellAlignment,
cellRect,
cellColor,
cellBgColor,
cellValue)

@SpencerIsGiddy
Copy link
Contributor Author

Ok, I’m not sure but is the change commit I just posted what you were asking?

@gustavo-iniguez-goya gustavo-iniguez-goya merged commit 5cdbd61 into evilsocket:master Feb 5, 2023
@gustavo-iniguez-goya
Copy link
Collaborator

Yep, that was it. Did you test the first commit? didn't it crash the gui on your system?

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants