Skip to content

comparison tables for EVM opcodes to ewasm methods and wasm instructions #81

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

comparison tables for EVM opcodes to ewasm methods and wasm instructions #81

wants to merge 4 commits into from

Conversation

cdetrio
Copy link
Contributor

@cdetrio cdetrio commented Feb 25, 2018

No description provided.

axic
axic reviewed Feb 26, 2018
View reviewed changes
axic
axic reviewed Feb 26, 2018
View reviewed changes
axic
axic reviewed Feb 26, 2018
View reviewed changes
evm_vs_ewasm_opcode_table.md Outdated
0x3a: GASPRICE | getTxGasPrice
0x3b: EXTCODESIZE | getExternalCodeSize
0x3c: EXTCODECOPY | externalCodeCopy
0x3d: RETURNDATASIZ | getReturnDataSize
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing last letter?

axic
axic reviewed Feb 26, 2018
View reviewed changes
axic
axic reviewed Feb 26, 2018
View reviewed changes
@cdetrio cdetrio force-pushed the opcode-table branch 2 times, most recently from bcc3ca0 to 425cd15 Compare March 1, 2018 01:45
jamesray1
jamesray1 approved these changes Mar 1, 2018
View reviewed changes
Copy link
Contributor

@jamesray1 jamesray1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I am not very confident as I could probably be more familiar with the Wasm and EWasm spec, having not read the latter and not having finished reading the former.

axic
axic reviewed Mar 19, 2018
View reviewed changes
@cdetrio cdetrio mentioned this pull request May 28, 2018
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@axic axic axic left review comments

@jamesray1 jamesray1 jamesray1 approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdetrio @axic @jamesray1