Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Drosophila euchromatin regions near centromere overshadowed by heterochromatin representation #189

Closed
rdcwuyy opened this issue Jan 18, 2020 · 3 comments

Comments

@rdcwuyy
Copy link

rdcwuyy commented Jan 18, 2020

Dear Eric,

Thanks for your fantastic work on the ideograms.

I found 3 regions (Chr2R, 3R and X) in the Drosophila ideogram misrepresented:
Annotation 2020-01-18 125352

There might be some small issues in the source code, but a temporary solution could be to delete these three lines from ...dist/data/bands/native/drosophila-melanogaster.json:
(1) "X q pter 1 10976635 1 10976635 gpos",
(2) "2R q pter 1 4460914 1 4460914 gpos",
(3) "3R q pter 1 30597427 1 30597427 gpos",

and we will get the following ideogram, which looks better:
Annotation 2020-01-18 125422

Thanks and best regards,
Yanying

@eweitz
Copy link
Owner

eweitz commented Jan 20, 2020

Thank you for the fix, @rdcwuyy! I implemented it in #190.

Ideogram gets its Drosophila banding data from NCBI Assembly. When I have more time, I plan to review the data issue more closely and report it to NCBI.

Also, since you gave rather precise and correct instructions for the fix, I'd like to add you to the authors list. If you'd like to be included, please reply here with your name and email.

@eweitz eweitz closed this as completed Jan 20, 2020
@eweitz eweitz reopened this Jan 20, 2020
@eweitz eweitz closed this as completed Jan 20, 2020
@rdcwuyy
Copy link
Author

rdcwuyy commented Jan 20, 2020

Thank you for the fix, @rdcwuyy! I implemented it in #190.

Ideogram gets its Drosophila banding data from NCBI Assembly. When I have more time, I plan to review the data issue more closely and report it to NCBI.

Also, since you gave rather precise and correct instructions for the fix, I'd like to add you to the authors list. If you'd like to be included, please reply here with your name and email.

Hi Eric,

Thanks for your kindness. It's my great honour to be on the author list, although I've done too little to be a genuine one. ;)

Anyway, my name is Yanying Wu and my email is yanying.wu@gmail.com

Cheers,
Yanying

@eweitz
Copy link
Owner

eweitz commented Jan 21, 2020

Added, cheers!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants