Rendering Optimization #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thank you Manfred! Merged. What email address should I use to credit you in the AUTHORS file? |
|
You can use mj3cheun@edu.uwaterloo.ca. Thanks again! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there! Noticed that with ideograms with large numbers of annotations (but this applies to ideograms with large numbers of elements in general), scrolling produced a good amount of lag. Did some digging into the cause and found that the following fixed it. Basically the following is an optimization trick to prevent repainting of every ideogram ele on page repaint. Here is an gif of the trick in action.
Thank you!