Add cursor support #218
Merged
Add cursor support #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added a new global function "ideogram.setCursorPosition" which works if you are using cursor support. - It would be nice to check for validattion of the position. - Also since `dist` files are versioned, I'm comitting the changes.
…e position of the curosr as well as the genomic coordinate used. There seems to be a magic number around 6 that makes the cursor work very closely to how the brush works.
|
@amanpatel, looks good -- thanks! What name and email should I add to AUTHORS? I merged this as-is. Usually I wouldn't do so for a non-trivial change without tests. But I lean towards this new cursor feature being combined into the brush feature, perhaps as a re-branded "selection" feature. For example, UCSC Genome Browser and NCBI Genome Data Viewer both support select-on-click in their chromosome graphic. However, they use the click's cursor position as the mid-point for a new range selection, rather than a point selection as done in this PR. |
Closed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to add basic cursor feature for chromosomes. The skeleton of the implementation follows the way
brush.jsis setup (since this is a very similar feature).Notes: