Fix issue with custom organism cytogenetic band files #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit c298c23.
|
I do not remember what I changed but apparently more things than just the commits were changed Going through the minified files to see what changed |
eweitz
approved these changes
Jul 23, 2022
There was a problem hiding this comment.
Thanks, @NicoNekoru! This looks good. I appreciate your detailed description of the issue with chickpea (Cicer arietinum) data over in #307.
I'll add you to AUTHORS. What name and email address should I use?
Also, if/when your genomics application is public, I'd be interested to see it!
|
Sounds great, Name: Kai Hidajat |
eweitz
changed the title
organismMetadata
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No breaking changes and doesn't affect anything unless user specifies
organismMetadataandtaxidin config.Not a true fix for #307 but resolves the issue if the parameters
organismMetadataandtaxidare specified