-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Restore centromere rendering #64
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This re-enables support for the display of centromeres in all eukaryotes (#58, #61).
The original implementation was broken by significant changes in Ideogram's code organization to support ploidy (#47). Support for centromeres and support for ploidy were implemented in parallel, and deploying the latter took precedence as it was added by a new contributor. This pull request is essentially a complex deferred merge.
Chimpanzee genome, with centromeres in pink:
http://eweitz.github.io/ideogram/eukaryotes.html?org=pan-troglodytes
This work also makes chromosome data files more consistent, which almost automatically enriches the rat ideogram.
Rat genome, with cytogenetic bands:
http://eweitz.github.io/ideogram/eukaryotes.html?org=rattus-norvegicus