feat(esl-utils): Support for window as a target for ESLResizeObserver… #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ala-n
reviewed
Apr 14, 2023
|
As soon as the comments above will be resolved, the request can be converted from the draft to an active proposal state |
ala-n
reviewed
Apr 26, 2023
src/modules/esl-event-listener/core/targets/resize.adapter.event.ts
Outdated
Show resolved
Hide resolved
src/modules/esl-event-listener/core/targets/resize.adapter.event.ts
Outdated
Show resolved
Hide resolved
ala-n
requested review from
a team,
abarmina and
NastaLeo
and removed request for
a team
ala-n
approved these changes
Apr 27, 2023
NastaLeo
approved these changes
May 2, 2023
dshovchko
approved these changes
May 4, 2023
yadamskaya
approved these changes
May 5, 2023
Natalie-Smirnova
approved these changes
May 8, 2023
Natalie-Smirnova
approved these changes
May 8, 2023
abarmina
approved these changes
May 8, 2023
|
Code Climate has analyzed commit b8c392d and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 35.7% (50% is the threshold). This pull request will bring the total coverage in the repository to 48.3% (-0.2% change). View more on Code Climate. |
ala-n
added
postponed
julia-murashko
approved these changes
May 22, 2023
ala-n
force-pushed
the
main
branch
6 times, most recently
from
1f18a8a to
6506db7
Compare
ala-n
force-pushed
the
main
branch
4 times, most recently
from
df09192 to
5f44df3
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.