Fix #345 TypeError: Cannot read property 'date1904' of undefined #364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guyonroche
requested changes
Jul 24, 2017
| @@ -127,7 +127,7 @@ utils.inherits(WorkbookXform, BaseXform, { | |||
| case 'workbook': | |||
| this.model = { | |||
| sheets: this.map.sheets.model, | |||
| properties: this.map.workbookPr.model, | |||
| properties: this.map.workbookPr.model || {}, | |||
There was a problem hiding this comment.
Looks good - could you also add a unit test that catches this issue?
in: spec/unit/xlsx/xform/book/workbook-xform.spec.js
best approach woud be making copies of the spec/unit/xlsx/xform/book/data/book.1.* files and adding a new expectation
There was a problem hiding this comment.
Sorry. No, actually I don't know how to add the unit test.
I just fixed an .xlsx file parsed with its this.map.workbookPr.model being undefined causing an null reference error.
This because the file itself having a missing property and exceljs supposing it have.
There was a problem hiding this comment.
OK, I have a little time now, I'll do it
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cant open xlsx saved from Numbers
model.properties is undefined