Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add support for stringifying event data with a maxDepth #25

Closed
srijken opened this issue Sep 14, 2015 · 3 comments
Closed

Add support for stringifying event data with a maxDepth #25

srijken opened this issue Sep 14, 2015 · 3 comments
Assignees
Labels

Comments

@srijken
Copy link
Contributor

srijken commented Sep 14, 2015

I received some HTTP error 413 calls in the console log. After inspection why the event submission failed, I found out it was about the send in over 5MB of stuff while posting as little as 3 events.

In this case it was caused by the angular integration / feature reporting, based on ngRoute.
Path of the biggest chunks of data data are

data.@request.current.locals.$template

and also

data.@request.next.locals.$template

$template should probably not be included in the events, but I'm not sure if there are others. Best idea might be to pick the properties that should be included, instead of keeping an exclusion list?

@niemyjski
Copy link
Member

I wanted to provide additional information about the previous and next routes for debugging but this can be a huge problem if the route contains templates and large amounts of scope info like yours. I almost think maybe we should be adding an overload for add object which takes a depth and an exclusion list and shrinks it so we only go two levels deep. What do you think about this?

@niemyjski niemyjski added the bug label Sep 15, 2015
@ejsmith
Copy link
Member

ejsmith commented Oct 11, 2015

Yeah, totally agreed that we need to add a max depth feature on the client. Also, the angular integration should add a global exclude for $template

@niemyjski
Copy link
Member

#37

@niemyjski niemyjski changed the title Angular integration can create events that exceed maximum size because templates are included Add support for stringifying event data with a maxDepth Feb 21, 2023
@niemyjski niemyjski self-assigned this Feb 21, 2023
niemyjski added a commit that referenced this issue Mar 1, 2023
niemyjski added a commit that referenced this issue Mar 17, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Development

No branches or pull requests

3 participants