Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Euler angles [incomplete] #57

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

mcclure
Copy link
Collaborator

@mcclure mcclure commented May 4, 2020

Sometime in January I needed euler angles so I threw together a quat.to_euler_angles function (and a quat.to_euler_angles_unpack function).

I would like to submit it back upstream but I think first this PR needs:

  • A from_euler_angles function
  • Tests
  • Some kind of better documentation, for example explaining what axis standard this to_euler_angles function uses. What standard does it use ?? … I'm not sure.

@coveralls
Copy link

coveralls commented May 4, 2020

Coverage Status

Coverage decreased (-0.3%) to 80.197% when pulling ae4601f on mcclure:euler-quat into ddb80f4 on excessive:master.

@mcclure
Copy link
Collaborator Author

mcclure commented Sep 2, 2021

I've been testing this in practice and I don't think it works.

Will post more about this later...

@FatalistError
Copy link

(he didn't post more about this later)

@mcclure
Copy link
Collaborator Author

mcclure commented Sep 11, 2023

I don't remember anymore what I was going to post about it later :(

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants