Update for Bob #184
Merged
Update for Bob #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
budmc29
suggested changes
Jul 21, 2018
exercises/bob/bob_test.sh
Outdated
| @@ -1,23 +1,23 @@ | |||
| #!/usr/bin/env bats | |||
|
|
|||
| @test "stating something." { | |||
| #skip | |||
| ##skip | |||
There was a problem hiding this comment.
yep I forgot to to :%s/#skip/skip/g in vim. thanks @budmc29
exercises/bob/bob_test.sh
Outdated
| run bash bob.sh "Tom-ay-to, tom-aaaah-to." | ||
|
|
||
| [ "$status" -eq 0 ] | ||
| [ "$output" = "Whatever." ] | ||
| } | ||
|
|
||
| @test "shouting" { | ||
| skip | ||
| #skip |
There was a problem hiding this comment.
All tests except the first one should be commented
There was a problem hiding this comment.
Do you mean only the first test should be commented?
|
Besides the miner issues with the comments this looks good to go. |
budmc29
reviewed
Jul 21, 2018
exercises/bob/bob_test.sh
Outdated
| @@ -212,7 +196,7 @@ | |||
| # This is commented out because it behaves differently on linux and mac | |||
There was a problem hiding this comment.
I think it's better to remove this test altogether, but it's your call.
There was a problem hiding this comment.
I'll remove it. Thanks for the feedback.
|
budmc29
approved these changes
Jul 21, 2018
|
Thank you for the PR. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After finally getting my local repo okay again
canonical-data- sort of1.2.0ifin the originalexample.shto get it to pass the forceful question test.ifto imitate the style found inexample.sh.closes #178
Reviewer Resources:
Track Policies