Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

connect: ensure generator is up-to-date #628

Closed
robphoenix opened this issue Apr 18, 2017 · 1 comment
Closed

connect: ensure generator is up-to-date #628

robphoenix opened this issue Apr 18, 2017 · 1 comment

Comments

@robphoenix
Copy link
Contributor

Parent issue: #604

Because of recent changes to make all the canonical-data.json files conform to
a common scheme (exercism/problem-specifications#625), it might be
the case that our current generator no longer runs.

For this exercise we need to make sure the current generator runs, and if it
doesn't then we need to update it.

In addition, the three lines at the top of the file:

// Source: {{.Ori}}
{{if .Commit}}// Commit: {{.Commit}}
{{end}}

can simply be replaced with {{.Header}}, which has the effect of:

  • Deprecating the Ori field, which is confusingly named
  • Showing the x-common version in the test file
  • Reducing duplicate code
@robphoenix robphoenix changed the title connect: ensure generator is up to date connect: ensure generator is up-to-date Apr 18, 2017
leenipper added a commit to leenipper/xgo that referenced this issue Apr 24, 2017
For issue exercism#628

Use .Header in template.
@leenipper
Copy link
Contributor

Closed by #647

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

No branches or pull requests

2 participants