Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

kindergarten-garden: check test version and update if necessary #997

Closed
N-Parsons opened this issue Oct 25, 2017 · 0 comments
Closed

kindergarten-garden: check test version and update if necessary #997

N-Parsons opened this issue Oct 25, 2017 · 0 comments

Comments

@N-Parsons
Copy link
Contributor

As identified in #784, some of the tests currently don't reference the version number for the canonical-data.json that they are based on, kindergarten-garden is one of them. In order to help with the ongoing maintenance of this track, we're in the process of checking the tests against the current version of the canonical-data.json - if they are up-to-date, then you can just add the version string, but if they are out-of-date, then the tests will need updating.

Tests should typically be ordered according to their order in the canonical data, since this makes it easier to check and update them in future. If you think that there's a better order, please let us know your reasoning in your PR.

If there are some additional tests that currently exist in this track but which aren't in the canonical data, these can be kept if you think that they are useful. They should be placed at the bottom of the test cases, and it would also be super-helpful if you could add a comment before them saying # Additional tests for this track to make it clear that they aren't part of the canonical data.

The version string should be placed just before the first test class and followed by a blank line. For this exercise, the version string is:

# Tests adapted from `problem-specifications//canonical-data.json` @ v1.0.0

Test suite: exercism/python/exercises/kindergarten-garden/kindergarten_garden_test.py
Canonical data: exercism/problem-specifications/exercises/kindergarten-garden/canonical-data.json

smalley added a commit to smalley/python that referenced this issue Oct 27, 2017
Renamed existing tests to match test case descriptions.
Deleted and added test cases to bring test list into agreement with data.
Added missing test version comment. Closes exercism#997
smalley added a commit to smalley/python that referenced this issue Oct 27, 2017
Renamed existing tests to match test case descriptions.
Deleted and added test cases to bring test list into agreement with data.
Added missing test version comment. Closes exercism#997
smalley added a commit to smalley/python that referenced this issue Oct 27, 2017
Renamed existing tests to match test case descriptions.
Deleted and added test cases to bring test list into agreement with data.
Added missing test version comment. Closes exercism#997
cmccandless pushed a commit that referenced this issue Oct 30, 2017
Renamed existing tests to match test case descriptions.
Deleted and added test cases to bring test list into agreement with data.
Added missing test version comment. Closes #997
smalley added a commit to smalley/python that referenced this issue Nov 12, 2017
Renamed existing tests to match test case descriptions.
Deleted and added test cases to bring test list into agreement with data.
Added missing test version comment. Closes exercism#997
smalley added a commit to smalley/python that referenced this issue Nov 12, 2017
Renamed existing tests to match test case descriptions.
Deleted and added test cases to bring test list into agreement with data.
Added missing test version comment. Closes exercism#997
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant