Skip to content
This repository was archived by the owner on Nov 23, 2022. It is now read-only.

Fix bugs related with docker-compose.yml deployments #16

Closed
wants to merge 3 commits into from

Conversation

niieani
Copy link
Contributor

@niieani niieani commented Sep 15, 2018

  • fix(compose): allow compose versions >= 3 5fdaa98
  • fix(compose): merge networks instead of replacing them ec3e9b0
  • fix(compose): use generated project names: using the same project in docker-compose versions > 3.6 and 3.7 causes 'docker-compose up' command to remove all the previous deployments

The change is hard to migrate to, because you essentially need to re-create all deployments with the correct stacks. Previously exoframe used the constant prefix as the project name for ALL docker-compose deployments (but this caused v3.6 deployments to automatically remove the previous one!), so now when updating a deployment you might get an error regarding conflicting containers. Not sure what to do about this.

using the same project in docker-compose versions > 3 causes 'docker-compose up' command to remove all the previous deployment
@yamalight
Copy link
Contributor

yamalight commented Sep 16, 2018

@niieani This is great stuff, thanks for the PR!
A few requests:

  1. Could you please check for compose version inside the swarm bit and return an error if it's not 3?
  2. Could you please add / adjust corresponding tests to make sure everything works as expected?

Upd: One more thing - could you please send the PR against develop branch as well?

Thank you!

@yamalight
Copy link
Contributor

OK, disregard the first comment - I should've looked at code more carefully 😑
I'm going to cherry pick allow compose versions >= 3 into 3.1 release I'm doing now.

Would still be open to accepting other changes with tests into develop branch 👍

yamalight added a commit that referenced this pull request Sep 19, 2018
@yamalight
Copy link
Contributor

I am going to close this. Feel free to send addition PR with rest of the changes.

@yamalight yamalight closed this Oct 9, 2018
@niieani
Copy link
Contributor Author

niieani commented Oct 9, 2018

@yamalight acknowledged! I didn't have time to add tests yet, I'll open up an issue for now though, since every deployment declaring a modern docker-compose version is broken.

# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants