Skip to content
This repository was archived by the owner on Nov 23, 2022. It is now read-only.

Update traefik.js #43

Merged
merged 15 commits into from
Apr 5, 2021
Merged

Update traefik.js #43

merged 15 commits into from
Apr 5, 2021

Conversation

FDiskas
Copy link
Contributor

@FDiskas FDiskas commented Apr 4, 2021

I want to try traefik custom ports. If it will work - then we could improve this

@FDiskas
Copy link
Contributor Author

FDiskas commented Apr 4, 2021

So - config would look like:

traefikPorts:
  - '7788/tcp': 
    - HostPort: '3000'
  - '7788/udp':
    - HostPort: '3000'

Copy link
Contributor

@yamalight yamalight left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small requests:

  1. Please add tests for new feature
  2. Please open issue / PR with docs on main repo

@FDiskas
Copy link
Contributor Author

FDiskas commented Apr 5, 2021

Sorry about allot of commits - have no ability to run tests locally hope you able to squash commits

FDiskas added a commit to FDiskas/exoframe that referenced this pull request Apr 5, 2021
@yamalight
Copy link
Contributor

Looks good, thanks!

@yamalight yamalight merged commit 8ece72e into exoframejs:develop Apr 5, 2021
@FDiskas FDiskas deleted the patch-1 branch April 5, 2021 22:05
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants