This repository was archived by the owner on Nov 23, 2022. It is now read-only.
This is just a start #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yamalight
suggested changes
Apr 18, 2020
There was a problem hiding this comment.
Awesome work!
Got a few minor comments.
One more awesome thing to have (in case you have a bit more time 😉) would be basic github actions setup (just "build" for everything to make sure it doesn't break, and some sort of release pipeline for github pages from tags)
|
Sorry - but github pages you should do by your self. It requires change repo settings, grab api key and pas it to action. ⏳ |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.