Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

InstancePool: min-available support #406

Conversation

tgrondier
Copy link
Member

@tgrondier tgrondier commented Dec 18, 2024

Description

Under the hood this is a full port of instancepool management and commands from egoscale v2 to egoscale v3!

Checklist

(For exoscale contributors)

  • Changelog updated (under Unreleased block)
  • Acceptance tests OK
  • For a new resource, datasource or new attributes: acceptance test added/updated

Testing

Acceptance tests:

TF_ACC=1 /usr/local/go/bin/go test                      \
        -race                   \
        -timeout=90m            \
        -tags=testacc           \
        -v -parallel=3 -count=1 -failfast   \
        github.com/exoscale/terraform-provider-exoscale/pkg/resources/instance_pool
=== RUN   TestInstancePool
=== RUN   TestInstancePool/DataSource
=== RUN   TestInstancePool/DataSourceList
=== RUN   TestInstancePool/Resource
--- PASS: TestInstancePool (167.55s)
    --- PASS: TestInstancePool/DataSource (57.13s)
    --- PASS: TestInstancePool/DataSourceList (41.89s)
    --- PASS: TestInstancePool/Resource (68.53s)
PASS
ok      github.com/exoscale/terraform-provider-exoscale/pkg/resources/instance_pool     168.582s

@tgrondier tgrondier changed the title InstancePool: move to egoscale v3 InstancePool: min-available support Dec 18, 2024
@tgrondier tgrondier marked this pull request as ready for review December 18, 2024 14:29
@tgrondier tgrondier force-pushed the tgrondier/sc-105855/tf-provider-instancepool-min-available-support branch from cd27a3e to 0c0ffc3 Compare December 24, 2024 12:32
@tgrondier tgrondier merged commit 27d980f into master Dec 24, 2024
2 of 3 checks passed
@tgrondier tgrondier deleted the tgrondier/sc-105855/tf-provider-instancepool-min-available-support branch December 24, 2024 14:46
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants