Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[expo-updates][android] modify DatabaseIntegrityCheck to match iOS behavior #12754

Merged
merged 2 commits into from
Apr 27, 2021

Conversation

esamelson
Copy link
Contributor

Why

Follow-up to #12683 (comment) .

Removes the unnecessary double meaning of the relative_path column in the assets table that was introduced in #12607. The presence of a value or NULL in relative_path no longer indicates whether or not we think the asset is currently present on disk; the meaning of the column is simply the path if the asset does indeed exist on disk.

The rest of the logic does not rely on the nullability of the field in this way, so there's no reason to introduce this added layer of meaning, and it will just lead to more confusion in the future (especially since it's Android-specific).

How

Update the behavior of DatabaseIntegrityCheck and its tests to match iOS; we now update the status of any update with missing assets but don't modify the entries for the assets themselves.

Test Plan

All unit tests pass.

Checklist

  • Documentation is up to date to reflect these changes (eg: https://docs.expo.io and README.md).
  • This diff will work correctly for expo build (eg: updated @expo/xdl).
  • This diff will work correctly for expo prebuild & EAS Build (eg: updated a module plugin).

@esamelson esamelson requested a review from jkhales April 27, 2021 18:58
@expo-bot
Copy link
Collaborator

Warnings
⚠️

📋 Missing Changelog

🛠 Add missing entries to:

🛠 Suggested fixes:

📋 Missing changelog

Apply suggested changes:

diff --git a/packages/expo-updates/CHANGELOG.md b/packages/expo-updates/CHANGELOG.md
index 429bc2be..ca66dd62 100644
--- a/packages/expo-updates/CHANGELOG.md
+++ b/packages/expo-updates/CHANGELOG.md
@@ -23,6 +23,7 @@
 ### 🐛 Bug fixes
 
 - Enable kotlin in all modules. ([#12716](https://github.com/expo/expo/pull/12716) by [@wschurman](https://github.com/wschurman))
+- modify DatabaseIntegrityCheck to match iOS behavior. ([#12754](https://github.com/expo/expo/pull/12754) by [@esamelson](https://github.com/esamelson))
 
 ## 0.6.0 — 2021-04-13
 

Generated by 🚫 dangerJS against 0f465b3

Copy link
Contributor

@jkhales jkhales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@esamelson esamelson merged commit e04a7cc into master Apr 27, 2021
@esamelson esamelson deleted the @eric/12683-followup-android branch April 27, 2021 22:41
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants