[expo-updates][android] modify DatabaseIntegrityCheck to match iOS behavior #12754
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Follow-up to #12683 (comment) .
Removes the unnecessary double meaning of the
relative_path
column in the assets table that was introduced in #12607. The presence of a value or NULL inrelative_path
no longer indicates whether or not we think the asset is currently present on disk; the meaning of the column is simply the path if the asset does indeed exist on disk.The rest of the logic does not rely on the nullability of the field in this way, so there's no reason to introduce this added layer of meaning, and it will just lead to more confusion in the future (especially since it's Android-specific).
How
Update the behavior of
DatabaseIntegrityCheck
and its tests to match iOS; we now update the status of any update with missing assets but don't modify the entries for the assets themselves.Test Plan
All unit tests pass.
Checklist
expo build
(eg: updated@expo/xdl
).expo prebuild
& EAS Build (eg: updated a module plugin).