[client] Update NewManifest field paths for new extra field format #13398
Conversation
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13398 (review)
wschurman
force-pushed
the
@wschurman/new-manifest-extra-fields
branch
from
a146a41 to
4a4e034
Compare
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13398 (review)
packages/expo-updates/android/src/main/java/expo/modules/updates/manifest/raw/RawManifest.kt
Show resolved
Hide resolved
There was a problem hiding this comment.
looks good to me, pending the discussion about the names of these fields in expo/expo-cli#3606.
| // use commitTime instead of publishedTime as it is more accurate; | ||
| // however, fall back to publishedTime in case older cached manifests do not contain | ||
| // the commitTime key (we have not always served it) | ||
| return getCommitTime() ?: getPublishedTime() |
There was a problem hiding this comment.
we should be able to safely remove this fallback, as we've been serving both fields for the entirety of the lifetimes of all SDK versions we currently support in Expo Go. I don't think the expo-updates runtime even looks at publishedTime.
There was a problem hiding this comment.
wschurman
force-pushed
the
@wschurman/new-manifest-extra-fields
branch
from
4a4e034 to
c1b33f4
Compare
There was a problem hiding this comment.
The review previously left here is no longer valid, jump to the latest one 👉 #13398 (review)
|
Failing test run tests are broken in master, landing. |
expo-bot
added
bot: passed checks
Why
expo/expo-cli#3606 defines the new format for the
extrafield.expoClientConfigcontains the fields necessary for the client to function (with the exception of scopeKey).expoGoConfigcontains the fields necessary for development using Expo Go.This PR updates the RawManifest and NewManifest to look in the new location for the fields it needs. Previously none of these fields were defined on the new manifest format.
How
Point field getters to new location in NewManifests.
Test Plan
In combination with expo/expo-cli#3606:
EXPO_DEBUG=true ~/expo/expo-cli/node_modules/.bin/expo startin a project.