Revert "[expo-update][iOS][android] save asset with a key that does n… #13733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhales
force-pushed
the
@jkhales/revert-ext-drop
branch
from
045b515 to
05be363
Compare
esamelson
approved these changes
Jul 22, 2021
jkhales
force-pushed
the
@jkhales/revert-ext-drop
branch
from
05be363 to
ef59ebc
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ot include an extension. (#12734)"
This reverts commit 63a0bdc.
Why
With the reversion detailed here: #13558 (comment)
We need to also revert this commit which relied on assets to be stored in the format introduced there.
Test Plan
Confirmed publishes of images worked and loaded from local source:
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).