[expo-updates][android][sqlite] make assets.type nullable #14499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhales
force-pushed
the
jonathan/eng-1928-fileextension-android
branch
from
3549e03 to
cc3c566
Compare
expo-bot
added
bot: passed checks
jkhales
commented
Sep 23, 2021
| }, | ||
| { | ||
| "tableName": "assets", | ||
| "createSql": "CREATE TABLE IF NOT EXISTS `${TABLE_NAME}` (`id` INTEGER PRIMARY KEY AUTOINCREMENT NOT NULL, `url` TEXT, `key` TEXT UNIQUE, `headers` TEXT, `type` TEXT, `metadata` TEXT, `download_time` INTEGER, `relative_path` TEXT, `hash` BLOB, `hash_type` INTEGER NOT NULL, `marked_for_deletion` INTEGER NOT NULL)", |
There was a problem hiding this comment.
Removed the index_assets_key index and replaced it with "key TEXT UNIQUE" to match the iOS schema.
jkhales
force-pushed
the
jonathan/eng-1928-fileextension-android
branch
from
46c9139 to
e5e22e1
Compare
jkhales
commented
Sep 23, 2021
| @@ -39,6 +39,8 @@ public static synchronized UpdatesDatabase getInstance(Context context) { | |||
| if (sInstance == null) { | |||
| sInstance = Room.databaseBuilder(context, UpdatesDatabase.class, DB_NAME) | |||
| .addMigrations(MIGRATION_4_5) | |||
| .addMigrations(MIGRATION_5_6) | |||
There was a problem hiding this comment.
added after discussion with @esamelson that it should have been included.
jkhales
force-pushed
the
jonathan/eng-1928-fileextension-android
branch
from
e3cc972 to
99233f3
Compare
jkhales
changed the title
esamelson
approved these changes
Sep 27, 2021
...dates/android/src/androidTest/java/expo/modules/updates/db/UpdatesDatabaseMigrationTest.java
Outdated
Show resolved
Hide resolved
Yea, the only place it gets read is here: https://github.com/expo/expo/blob/master/packages/expo-updates/android/src/main/java/expo/modules/updates/UpdatesUtils.java#L126 |
added 11 commits
September 28, 2021 04:56
jkhales
force-pushed
the
jonathan/eng-1928-fileextension-android
branch
from
99233f3 to
8917bec
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Make the "type" column in the "assets" table nullable.
Since launch assets don't require a file extension, we are no longer sending one.
We want to make iOS match this behavior in a future PR.
How
Followed this: #12084
Test Plan
made new tests and confirmed on a demo repo that loading a project that has no file extension included with its launch asset, served by
expo start, crashes Expo Go and after this PR is applied no longer crashes it.Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).