[expo-updates] add iOS database migration for error recovery fields #14718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkhales
approved these changes
Oct 15, 2021
packages/expo-updates/ios/Tests/EXUpdatesDatabaseInitializationTests.m
Outdated
Show resolved
Hide resolved
expo-bot
added
bot: passed checks
3 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
follow up to #14610 - add a migration to add these new fields to existing DBs
How
followed our new handy-dandy migration guide 😄 and basically copied what I had done for the previous migration (which was also adding a column to the same table)
Test Plan
Added a new unit test for the new migration, and ensured all existing tests still pass
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).