[packages] Remove backward compatible workarounds and drop react-native 0.64 support #16446
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
expo-bot
added
bot: passed checks
2 tasks
Kudo
requested review from
esamelson,
tsapeta,
bbarthec and
barthap
as code owners
tsapeta
approved these changes
Feb 25, 2022
barthap
approved these changes
Feb 28, 2022
| @@ -778,7 +775,7 @@ open class FileSystemModule( | |||
| } | |||
|
|
|||
| val body = createRequestBody(options, decorator, fileUri.toFile()) | |||
| return requestBuilder.method(method, body).build() | |||
| return method?.let { requestBuilder.method(method, body).build() } | |||
There was a problem hiding this comment.
Good catch - previously this could throw NPE when method was null for some reason.
There was a problem hiding this comment.
Good catch - previously this could throw NPE when
methodwasnullfor some reason.
thank to okhttp kotlin migration help to report this compile error 😂
bbarthec
approved these changes
Feb 28, 2022
Kudo
added a commit
that referenced
this pull request
Feb 28, 2022
…pgrade (#16401) # Why for sdk45 and based on #16400 # How - [tools] Fix versioning tools for react-native 0.67.2 upgrade - [expo-modules-core][ios] Fix missing `EX` prefix to some objective-c files for versioning support - [autolinking] Apply our cocoapods fix for `React-Core` swift support to versioned code - [expo-updates] fix an incompatible `ReactInstanceManager` in UpdatesPackage where UpdateController is unversioned but UpdatePackage is versioned. - [expo-file-system] okhttp/okio code for new versioned code build successfully. this is done in #16446 # Test Plan - `et add-sdk -p android -s 45.0.0` and build/launch sdk 45 expo go with sdk 45 ncl - `et add-sdk -p ios -s 45.0.0` and build/launch sdk 45 expo go with sdk 45 ncl
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
basically because we cannot apply the okhttp/okio workaround to expo go versioned code. maintaining these workarounds increase maintenance cost. since we are doing expo modules for next sdk based on react-native 0.67 or even 0.68, there's no reason we should keep backward compatible with 0.64.
How
EXComponentDataCompatibleWrapperfrom expo-modules-coreTest Plan
Checklist
expo build(eg: updated@expo/xdl).expo prebuild& EAS Build (eg: updated a module plugin).