[expo-updates][android][1/n] Refactor responsibility #24954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wschurman
force-pushed
the
@wschurman/android-module-override-2
branch
from
df1c457 to
658ab70
Compare
wschurman
force-pushed
the
@wschurman/android-module-override-2
branch
from
658ab70 to
e5d300e
Compare
douglowder
approved these changes
Oct 24, 2023
wschurman
force-pushed
the
@wschurman/android-module-override-2
branch
from
e5d300e to
cbcd787
Compare
expo-bot
added
bot: passed checks
marklawlor
pushed a commit
that referenced
this pull request
Oct 30, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Similar to #24934 but we're not quite in a position to make a lot of the controller fields private yet (compared to iOS). Think I need to backport the expo go versioned module stuff to older SDKs.
How
Similar strategy to #24934: move methods into the controller to start to centralize logic so that hopefully we can combine the logic and better reason about state machine updates.
Test Plan
Wait for CI.
Checklist
npx expo prebuild& EAS Build (eg: updated a module plugin).