[expo-updates] Asset exclusion on Android part 1 #25277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
douglowder
force-pushed
the
doug/eng-9910-remove-expo-updates-requirement-that-all-assets-be-present
branch
from
788189d to
bdeaa81
Compare
wschurman
approved these changes
Nov 9, 2023
packages/expo-updates/android/src/main/java/expo/modules/updates/launcher/DatabaseLauncher.kt
Outdated
Show resolved
Hide resolved
packages/expo-updates/android/src/main/java/expo/modules/updates/launcher/DatabaseLauncher.kt
Show resolved
Hide resolved
Co-authored-by: Will Schurman <wschurman@expo.io>
douglowder
commented
Nov 10, 2023
packages/expo-updates/android/src/main/java/expo/modules/updates/launcher/DatabaseLauncher.kt
Outdated
Show resolved
Hide resolved
expo-bot
added
bot: passed checks
douglowder
deleted the
doug/eng-9910-remove-expo-updates-requirement-that-all-assets-be-present
branch
3 tasks
onizam95
pushed a commit
to onizam95/expo-av-drm
that referenced
this pull request
Jan 15, 2024
# Why Allow Android to make use of updates created with only some assets included (using the CLI changes in expo#25065 ). # How - Make Android work with updates that don't include all assets - Limitations: - Android still needs to copy embedded assets to the updates folder - Fonts (which are packaged as resources in Android) still need to be part of updates Limitations will be addressed in future PRs. # Test Plan - Manual testing with a custom test app - The app has Expo config with `extra.updates.assetPatternsToBeBundled = "assetsInUpdates/*"` - Start with some assets (images and fonts) in a different folder (e.g. `embeddedAssets`) - App starts up, embedded bundle works and shows all images and fonts - Add a new image in `embeddedAssets`, run `eas update` and download and launch update - App works, but image will not show in UI - Now move that image to the `assetsInUpdates` folder, and change `App.tsx` accordingly - Run `eas update` again, download and run update - The new image will now show up correctly in the UI - Updates E2E should continue to pass (confirming that this does not break existing behavior) # Checklist - [x] Documentation is up to date to reflect these changes (eg: https://docs.expo.dev and README.md). - [x] Conforms with the [Documentation Writing Style Guide](https://github.com/expo/expo/blob/main/guides/Expo%20Documentation%20Writing%20Style%20Guide.md) - [x] This diff will work correctly for `npx expo prebuild` & EAS Build (eg: updated a module plugin). --------- Co-authored-by: Will Schurman <wschurman@expo.io>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
Allow Android to make use of updates created with only some assets included (using the CLI changes in #25065 ).
How
Limitations will be addressed in future PRs.
Test Plan
extra.updates.assetPatternsToBeBundled = "assetsInUpdates/*"embeddedAssets)embeddedAssets, runeas updateand download and launch updateassetsInUpdatesfolder, and changeApp.tsxaccordinglyeas updateagain, download and run updateChecklist
npx expo prebuild& EAS Build (eg: updated a module plugin).