Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[expo-updates] Improve JS API error messages and documentation for Expo Go and Dev Client #25751

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

wschurman
Copy link
Member

Why

Closes ENG-10765.

Using these methods is no longer supported when in expo go, dev client, or when updates is disabled. This is part of a larger effort to make it clearer what the state of the expo-updates system is, and not have pieces of it partially functional while others fail silently.

How

Update error messages and docs.

Test Plan

Inspect.

Checklist

@wschurman wschurman requested a review from douglowder as a code owner December 4, 2023 21:25
Copy link

linear bot commented Dec 4, 2023

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Dec 4, 2023
@wschurman wschurman force-pushed the @wschurman/error-messages branch from 01919b9 to 85a01b5 Compare December 5, 2023 03:48
@wschurman wschurman merged commit e4d2787 into main Dec 5, 2023
@wschurman wschurman deleted the @wschurman/error-messages branch December 5, 2023 03:48
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Dec 5, 2023
onizam95 pushed a commit to onizam95/expo-av-drm that referenced this pull request Jan 15, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants