Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[expo-updates] Add expo-updates cli fingerprint:generate command #27119

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

wschurman
Copy link
Member

Why

We need the @expo/fingerprint package version to match that of expo-updates (the fingerprint generated during the build from #26901) when we generate a fingerprint in eas-cli for the eas update command. The only way I can think to do this is make a command in expo-updates that eas-cli calls into to get the version of @expo/fingerpring being used by the project (and build process). This is similar to how we call npx expo from eas-cli to get the correct versioned CLI.

How

Add new command, yarn expo-updates fingerprint:generate --platform ios that just runs fingerprint. This has the secondary benefit of consolidating the workflow detection code to one place as well so there aren't any inconsistencies.

Test Plan

yarn expo-updates fingerprint:generate --platform ios
see JSON fingerprint output stringified

Checklist

@wschurman wschurman force-pushed the @wschurman/add-expo-updates-fingerprint-cli branch from 631966e to d671990 Compare February 16, 2024 22:02
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Feb 16, 2024
@wschurman wschurman merged commit fe283f8 into main Feb 16, 2024
13 checks passed
@wschurman wschurman deleted the @wschurman/add-expo-updates-fingerprint-cli branch February 16, 2024 22:05
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bot: fingerprint compatible bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants