Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[expo-updates] Expose emergency launch reason on constants #27714

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented Mar 16, 2024

Why

Previously, the only way to find out why expo-updates may have failed to initialize was to look at the Expo-Fatal-Error header of the manifest request.

This PR adds a second method, a constant in the JS module.

Closes ENG-11739.

How

Expose the error message to a JS field.

Test Plan

Build. We don't currently have tests for these cases because they're rare and hard to reproduce. May look into adding a e2e test where we force an error, but that could prove to be an uphill battle.

Checklist

Copy link

linear bot commented Mar 16, 2024

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Mar 16, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented Mar 16, 2024

The Pull Request introduced fingerprint changes against the base commit: bb80091

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-updates/android",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "8c8ab657e64a5547ed2a4ec9647ce8b1db38313d"
  }
]

Generated by PR labeler 🤖

@wschurman wschurman force-pushed the @wschurman/expose-emergency-launch-reason branch 2 times, most recently from b5bce63 to 655e3b3 Compare March 18, 2024 03:52
@wschurman wschurman marked this pull request as ready for review March 18, 2024 03:52
@wschurman wschurman requested a review from douglowder as a code owner March 18, 2024 03:52
@wschurman wschurman requested a review from douglowder March 18, 2024 15:37
@wschurman wschurman force-pushed the @wschurman/expose-emergency-launch-reason branch from b7692fd to 1643d21 Compare March 19, 2024 00:36
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Mar 19, 2024
@wschurman wschurman merged commit 3fd4606 into main Mar 19, 2024
25 of 28 checks passed
@wschurman wschurman deleted the @wschurman/expose-emergency-launch-reason branch March 19, 2024 00:49
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Apr 18, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants