Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[updates] fix fingerprint policy start error on debug build #28912

Merged

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented May 16, 2024

Why

fix android launch crash when a project using fingerprint runtime version policy with expo-updates and expo-dev-client
close ENG-12299

How

the crash is because on debug build we didn't generate the fingerprint file. this pr tries to generate fingerprint on debug build. this is aligned with our implementation on ios:

CREATE_UPDATES_RESOURCES_MODE="all"
if [[ "$SKIP_BUNDLING" ]]; then
echo "SKIP_BUNDLING enabled; skipping create-manifest-ios.sh."
CREATE_UPDATES_RESOURCES_MODE="only-fingerprint"
elif [[ "$CONFIGURATION" == *Debug* ]]; then
if [[ "$FORCE_BUNDLING" ]]; then
echo "FORCE_BUNDLING enabled; continuing create-manifest-ios.sh."
else
CREATE_UPDATES_RESOURCES_MODE="only-fingerprint"
fi
fi

Test Plan

$ yarn create expo -t blank@sdk-51 sdk51
$ npx expo install expo-dev-client expo-updates
$ eas update:configure
# change runtimeVersion.policy to "fingerprint"
$ npx expo run:android

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 16, 2024
@expo-bot
Copy link
Collaborator

expo-bot commented May 16, 2024

The Pull Request introduced fingerprint changes against the base commit: ec256db

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-updates/expo-updates-gradle-plugin",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "5a34e34343ec9b806b643e2097bf6d6276fa24e2"
  }
]

Generated by PR labeler 🤖

@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 16, 2024
@Kudo Kudo marked this pull request as ready for review May 16, 2024 11:12
@Kudo Kudo requested review from wschurman and douglowder as code owners May 16, 2024 11:12
@Kudo Kudo merged commit 722e5a4 into main May 16, 2024
27 checks passed
@Kudo Kudo deleted the @kudo/eng-12299-user-reporting-updates-crash-on-sdk-51-android-with branch May 16, 2024 15:44
Kudo added a commit that referenced this pull request May 16, 2024
# Why

fix android launch crash when a project using fingerprint runtime
version policy with expo-updates and expo-dev-client
close ENG-12299

# How

the crash is because on debug build we didn't generate the fingerprint
file. this pr tries to generate fingerprint on debug build. this is
aligned with our implementation on ios

(cherry picked from commit 722e5a4)
@brentvatne brentvatne added the published Changes from the PR have been published to npm label May 16, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants