-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[updates] fix fingerprint policy start error on debug build #28912
Merged
Kudo
merged 2 commits into
main
from
@kudo/eng-12299-user-reporting-updates-crash-on-sdk-51-android-with
May 16, 2024
Merged
[updates] fix fingerprint policy start error on debug build #28912
Kudo
merged 2 commits into
main
from
@kudo/eng-12299-user-reporting-updates-crash-on-sdk-51-android-with
May 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pull Request introduced fingerprint changes against the base commit: ec256db Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-updates/expo-updates-gradle-plugin",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "5a34e34343ec9b806b643e2097bf6d6276fa24e2"
}
] Generated by PR labeler 🤖 |
wschurman
approved these changes
May 16, 2024
Kudo
added a commit
that referenced
this pull request
May 16, 2024
# Why fix android launch crash when a project using fingerprint runtime version policy with expo-updates and expo-dev-client close ENG-12299 # How the crash is because on debug build we didn't generate the fingerprint file. this pr tries to generate fingerprint on debug build. this is aligned with our implementation on ios (cherry picked from commit 722e5a4)
This was referenced May 18, 2024
This was referenced May 19, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
bot: fingerprint changed
bot: passed checks
ExpoBot has nothing to complain about
published
Changes from the PR have been published to npm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
fix android launch crash when a project using fingerprint runtime version policy with expo-updates and expo-dev-client
close ENG-12299
How
the crash is because on debug build we didn't generate the fingerprint file. this pr tries to generate fingerprint on debug build. this is aligned with our implementation on ios:
expo/packages/expo-updates/scripts/create-updates-resources-ios.sh
Lines 5 to 16 in 2cf0578
Test Plan
$ yarn create expo -t blank@sdk-51 sdk51 $ npx expo install expo-dev-client expo-updates $ eas update:configure # change runtimeVersion.policy to "fingerprint" $ npx expo run:android
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).