-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[expo-updates][android] Change from kapt to ksp for room #29055
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cc @nmajumder12 |
The Pull Request introduced fingerprint changes against the base commit: 79fd5fa Fingerprint diff[
{
"type": "dir",
"filePath": "../../packages/expo-updates/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "0b685df832af68a1ad9040de1d04eec9225c0035"
}
] Generated by PR labeler 🤖 |
Kudo
requested changes
May 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just the kspVersion
that we could use the one controlled from expo-modules-core
d2d58f6
to
6d1a4aa
Compare
3 tasks
Kudo
approved these changes
May 23, 2024
6d1a4aa
to
53a7111
Compare
@wschurman Thank you, that worked |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
It looks like #28806 wasn't sufficient to fix #28657. This changes expo-updates to use ksp instead of kapt, which is the suggested method going forward anyways.
Closes ENG-12257.
How
Update to ksp. Copy the strategy of adding ksp to a library (versus a project) from react-native-async-storage.
Test Plan
Build app. Updates e2e tests as well.
Also test uncommenting the schema generation for tests.
Checklist
npx expo prebuild
& EAS Build (eg: updated a module plugin).