Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[expo-updates][android] Change from kapt to ksp for room #29055

Merged
merged 1 commit into from
May 24, 2024

Conversation

wschurman
Copy link
Member

@wschurman wschurman commented May 22, 2024

Why

It looks like #28806 wasn't sufficient to fix #28657. This changes expo-updates to use ksp instead of kapt, which is the suggested method going forward anyways.

Closes ENG-12257.

How

Update to ksp. Copy the strategy of adding ksp to a library (versus a project) from react-native-async-storage.

Test Plan

Build app. Updates e2e tests as well.

Also test uncommenting the schema generation for tests.

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label May 22, 2024
@wschurman
Copy link
Member Author

cc @nmajumder12

@expo-bot
Copy link
Collaborator

expo-bot commented May 22, 2024

The Pull Request introduced fingerprint changes against the base commit: 79fd5fa

Fingerprint diff
[
  {
    "type": "dir",
    "filePath": "../../packages/expo-updates/android",
    "reasons": [
      "expoAutolinkingAndroid"
    ],
    "hash": "0b685df832af68a1ad9040de1d04eec9225c0035"
  }
]

Generated by PR labeler 🤖

Copy link

linear bot commented May 22, 2024

@wschurman wschurman marked this pull request as ready for review May 22, 2024 18:57
@wschurman wschurman requested a review from douglowder as a code owner May 22, 2024 18:57
@wschurman wschurman requested a review from Kudo May 22, 2024 18:57
Copy link
Contributor

@Kudo Kudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just the kspVersion that we could use the one controlled from expo-modules-core

@wschurman wschurman force-pushed the @wschurman/change-expo-updates-to-ksp branch from 6d1a4aa to 53a7111 Compare May 24, 2024 16:32
@wschurman wschurman merged commit 1cf6b27 into main May 24, 2024
16 of 19 checks passed
@wschurman wschurman deleted the @wschurman/change-expo-updates-to-ksp branch May 24, 2024 16:32
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels May 24, 2024
@nmajumder12
Copy link

@wschurman Thank you, that worked

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants