-
Notifications
You must be signed in to change notification settings - Fork 6.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
[updates] add runtime URL and headers override on android #34422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Pull Request introduced fingerprint changes against the base commit: 9b6150f Fingerprint diff[
{
"op": "changed",
"beforeSource": {
"type": "dir",
"filePath": "../../packages/expo-updates/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "530fbac7d65f3e13ad753ce5d394ed3bb44e795d"
},
"afterSource": {
"type": "dir",
"filePath": "../../packages/expo-updates/android",
"reasons": [
"expoAutolinkingAndroid"
],
"hash": "27884d0afbef19599fac92aa14ff786bdef0db5a"
}
}
] Generated by PR labeler 🤖 |
f579620
to
55ec34d
Compare
This was referenced Jan 24, 2025
3fac743
to
fe4e562
Compare
Subscribed to pull request
Generated by CodeMention |
fe4e562
to
7e7ad07
Compare
wschurman
reviewed
Jan 24, 2025
packages/expo-updates/android/src/main/java/expo/modules/updates/UpdatesConfiguration.kt
Outdated
Show resolved
Hide resolved
packages/expo-updates/android/src/main/java/expo/modules/updates/UpdatesConfiguration.kt
Outdated
Show resolved
Hide resolved
...ages/expo-updates/android/src/main/java/expo/modules/updates/UpdatesConfigurationOverride.kt
Outdated
Show resolved
Hide resolved
wschurman
approved these changes
Jan 24, 2025
Kudo
added a commit
that referenced
this pull request
Feb 4, 2025
(cherry picked from commit ec0732f)
Kudo
added a commit
that referenced
this pull request
Feb 4, 2025
(cherry picked from commit ec0732f)
Kudo
added a commit
that referenced
this pull request
Feb 5, 2025
(cherry picked from commit ec0732f)
Kudo
added a commit
that referenced
this pull request
Feb 5, 2025
(cherry picked from commit ec0732f)
brentvatne
pushed a commit
that referenced
this pull request
Feb 6, 2025
(cherry picked from commit ec0732f)
brentvatne
pushed a commit
that referenced
this pull request
Feb 21, 2025
(cherry picked from commit ec0732f)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Labels
bot: fingerprint changed
bot: passed checks
ExpoBot has nothing to complain about
published
Changes from the PR have been published to npm
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
allow overriding url and request headers in runtime. this opens the possibility to load specific url and may brick the app
How
disableAntiBrickingMeasures
build-time config to allow overrides in runtimeUpdates.setUpdatesURLAndRequestHeadersOverride
to set the overridesTest Plan
will has an e2e test later
Checklist
changelog.md
entry and rebuilt the package sources according to this short guidenpx expo prebuild
& EAS Build (eg: updated a module plugin).