Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[updates] add runtime URL and headers override on android #34422

Merged
merged 3 commits into from
Jan 24, 2025

Conversation

Kudo
Copy link
Contributor

@Kudo Kudo commented Jan 24, 2025

Why

allow overriding url and request headers in runtime. this opens the possibility to load specific url and may brick the app

How

  • add disableAntiBrickingMeasures build-time config to allow overrides in runtime
  • add Updates.setUpdatesURLAndRequestHeadersOverride to set the overrides
Co-authored-by: Will Schurman <wschurman@expo.io>

Test Plan

will has an e2e test later

Checklist

@expo-bot expo-bot added the bot: suggestions ExpoBot has some suggestions label Jan 24, 2025
@Kudo Kudo changed the title [updates] add runtime overrides support [updates] add runtime URL and headers override capability Jan 24, 2025
@expo-bot
Copy link
Collaborator

expo-bot commented Jan 24, 2025

The Pull Request introduced fingerprint changes against the base commit: 9b6150f

Fingerprint diff
[
  {
    "op": "changed",
    "beforeSource": {
      "type": "dir",
      "filePath": "../../packages/expo-updates/android",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "530fbac7d65f3e13ad753ce5d394ed3bb44e795d"
    },
    "afterSource": {
      "type": "dir",
      "filePath": "../../packages/expo-updates/android",
      "reasons": [
        "expoAutolinkingAndroid"
      ],
      "hash": "27884d0afbef19599fac92aa14ff786bdef0db5a"
    }
  }
]

Generated by PR labeler 🤖

@Kudo Kudo changed the title [updates] add runtime URL and headers override capability [updates] add runtime URL and headers override on android Jan 24, 2025
@expo-bot expo-bot added bot: passed checks ExpoBot has nothing to complain about and removed bot: suggestions ExpoBot has some suggestions labels Jan 24, 2025
@Kudo Kudo force-pushed the @kudowill/upload-config-override-1 branch from f579620 to 55ec34d Compare January 24, 2025 07:40
@Kudo Kudo force-pushed the @kudowill/upload-config-override-1 branch from 3fac743 to fe4e562 Compare January 24, 2025 18:39
@Kudo Kudo mentioned this pull request Jan 24, 2025
3 tasks
@Kudo Kudo marked this pull request as ready for review January 24, 2025 19:08
@Kudo Kudo requested a review from wschurman January 24, 2025 19:09
Copy link
Contributor

Subscribed to pull request

File Patterns Mentions
packages/expo-updates/** @wschurman, @douglowder

Generated by CodeMention

@wschurman wschurman force-pushed the @kudowill/upload-config-override-1 branch from fe4e562 to 7e7ad07 Compare January 24, 2025 20:01
Copy link
Member

wschurman commented Jan 24, 2025

Merge activity

  • Jan 24, 6:05 PM EST: A user started a stack merge that includes this pull request via Graphite.
  • Jan 24, 6:05 PM EST: A user merged this pull request with Graphite.

@wschurman wschurman merged commit ec0732f into main Jan 24, 2025
21 of 22 checks passed
@wschurman wschurman deleted the @kudowill/upload-config-override-1 branch January 24, 2025 23:05
Kudo added a commit that referenced this pull request Feb 4, 2025
Kudo added a commit that referenced this pull request Feb 4, 2025
Kudo added a commit that referenced this pull request Feb 5, 2025
Kudo added a commit that referenced this pull request Feb 5, 2025
brentvatne pushed a commit that referenced this pull request Feb 6, 2025
brentvatne pushed a commit that referenced this pull request Feb 21, 2025
@brentvatne brentvatne added the published Changes from the PR have been published to npm label Feb 21, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bot: fingerprint changed bot: passed checks ExpoBot has nothing to complain about published Changes from the PR have been published to npm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants