Skip to content

Refactor getCharset function for conciseness and modern syntax #557

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Refactor getCharset function for conciseness and modern syntax #557

wants to merge 2 commits into from

Conversation

Ayoub-Mabrouk
Copy link

  • Utilized optional chaining to simplify charset retrieval
  • Improved JSDoc comments for clarity
  • Enhanced readability while maintaining functionality

@Ayoub-Mabrouk
Refactor getCharset function for conciseness and modern syntax
1f86ea0 
- Utilized optional chaining to simplify charset retrieval
- Improved JSDoc comments for clarity
- Enhanced readability while maintaining functionality
bjohansebas
bjohansebas reviewed Nov 2, 2024
View reviewed changes
@Ayoub-Mabrouk @bjohansebas
Update lib/types/urlencoded.js
742016d 
Co-authored-by: Sebastian Beltran <bjohansebas@gmail.com>
wesleytodd
wesleytodd requested changes Nov 14, 2024
View reviewed changes
Copy link
Member

@wesleytodd wesleytodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as the other one. Lets discuss this kind of thing at the TC.

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@wesleytodd wesleytodd wesleytodd requested changes

@UlisesGascon UlisesGascon UlisesGascon approved these changes

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Ayoub-Mabrouk @wesleytodd @UlisesGascon @bjohansebas