Skip to content

Refactor JSONCookies function for improved readability and modern syntax #119

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Refactor JSONCookies function for improved readability and modern syntax #119

wants to merge 1 commit into from

Conversation

Ayoub-Mabrouk
Copy link

  • Replaced Object.keys() with Object.entries() for cleaner iteration over key-value pairs.
  • Utilized destructuring in the loop to enhance code clarity.
  • Improved variable naming for better understanding of the decoded value.
  • Maintained functionality of decoding JSON cookies while updating the original object.

@Ayoub-Mabrouk
Refactor JSONCookies function for improved readability and modern syntax
d9f2aa6 
- Replaced Object.keys() with Object.entries() for cleaner iteration over key-value pairs.
- Utilized destructuring in the loop to enhance code clarity.
- Improved variable naming for better understanding of the decoded value.
- Maintained functionality of decoding JSON cookies while updating the original object.
@UlisesGascon
Copy link
Member

We don't have support for ES syntax yet as we support Node@0.8

https://github.com/expressjs/cookie-parser/actions/runs/11623042363/job/32384208780?pr=119
Screenshot from 2024-11-01 12-30-19

This was referenced Nov 1, 2024
Open
Open
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
semver-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ayoub-Mabrouk @UlisesGascon